search

cloudfoundry / cf-java-client

Java Client Library for Cloud Foundry
Apache License 2.0
328 stars 318 forks source link

Releases with major version 4.x #1144

Closed theghost5800 closed 2 years ago

theghost5800 commented 2 years ago

Hi, Thank you for providing new release version(5.7.0). I would like to ask you can we have release with 4.x version including same changes from 5.7.0 ? I am asking this because we have issues when we are trying to use 5.6.0 or 5.7.0 with http requests monitoring in our monitoring environment Dynatrace. Some of introduced changes in major version 5 cause monitoring of http requests made by cf-java-client-reactor to not show there. At first I was thinking that the main issue could be caused by newer reactor-netty client used in 5.x versions - reactor-netty 1.0.3 but when I try to make http request directly using HttpClient class, then the request is detected by Dynatrace properly. So I have 2 questions:

Thanks, Kristian

dmikusa commented 2 years ago

I don't know that I can get to it this week, but I will try to get a release cut for you as soon as I have a free moment.

For what it's worth, we're only cutting 4.x releases on request now. The 4.x branch is meant to be used with Spring Boot 2.3 and that version went EOGS on 2021-05-20. See https://spring.io/projects/spring-boot#support. It hasn't been announced but at some point later this year, we'll stop cutting releases altogether on the 4.x line and mark it EOGS as well.

We strongly recommend at this point that all users have upgraded to a supported version of Spring Boot, for reasons like the recent RCE CVE in Spring, and as such that means using cf-java-client 5.x, which has been validated with Spring Boot 2.4-2.6 (at the time I write this).

dmikusa commented 2 years ago

I forgot your second question:

Can you share with me what are major changes between cf-java-client 4.x and 5.x versions?

The branches are pretty similar. The main difference is that they are intended to work with different versions of Spring Boot. 4.x -> SB 2.3, 4.5 -> SB 2.4+. This in turn pulls in a different set of dependencies.

I wasn't around on the project when the decision was originally made so I don't know how different the dependencies were, but I assume there were some API changes in the underlying dependencies that were difficult to accommodate in one version of cf-java-client that worked on both SB 2.3 and 2.4.

Going forward, we're planning to keep 5.x as the underlying dependencies work across SB 2.4-2.6. When we get closer to SB 3.0, we'll evaluate if we can continue to keep everyone on 5.x or if a 6.x will be necessary for SB 3.0 compatibility.

dmikusa commented 2 years ago

Apologizes, this took a bit to get the CI passing. I've cut the release this morning.

https://github.com/cloudfoundry/cf-java-client/releases/tag/v4.17.0.RELEASE

The CI is running to publish the release. It typically takes about 1.5h to run. Test flakiness is not uncommon though so it could take longer. I will keep an eye on it and re-run if necessary. With any luck, the 4.17.0 release should be up on Maven central shortly.

dmikusa commented 2 years ago

CI has all passed. The release should be published to Maven Central now.

theghost5800 commented 2 years ago

Hi @dmikusa-pivotal , I am really thankful for provided release version 4.17.0 :)