search

cloudfoundry / cf-java-client

Java Client Library for Cloud Foundry
Apache License 2.0
328 stars 318 forks source link

Implement Manifest V3 objects and deployment #1167

Closed schulzh closed 2 years ago

schulzh commented 2 years ago

Implements:

I hope that the pushManifestV3 operation is complete (especially the "app readiness" checks), since I did not find a documentation of this process and had to reverse engineer it from the CLI.

I chose to pass a raw byte array as manifest in the client instead of an object, because that would've required to add the snakeyaml dependency to the client as well. Since the manifest is just passed to and applied by the CC anyway, I saw no benefit of passing as an object.

Unfortunately, I could not get a local CF instance set up for the integration tests. Due to licensing issues at my company I cannot use Virtualbox and setting it up on a local OpenStack "DevStack" instance wasn't working either. If requested, I can add integration tests, but I cannot ensure that they are working as intended.

Solves #999 and #1142 but not #1103 yet

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

pivotal-david-osullivan commented 2 years ago

Thanks for the PR @schulzh! Are you able to follow the link in the EasyCLA comment above to get the commit authorised ✅ and satisfy the bot?

SInce this is a significant addition, if you can add the integration tests I am happy to run them in a lab!

schulzh commented 2 years ago

I have already done the EasyCLA process and I'm waiting on the approval of my organization. I'll add integration tests then, thanks!

schulzh commented 2 years ago

Hi @pivotal-david-osullivan,

I've added integration tests. Could you please run them in your lab? I've also completed the CLA. From my side this PR should be ready to merge, so I'd be happy to have it reviewed.

schulzh commented 2 years ago

Hi @mheath ,

Thank you for the review and kind words :slightly_smiling_face:

I've addressed the issues, please take a look.

mheath commented 2 years ago

Will you change the branch from main to manifest-v3 on this PR and I will get it merged and then merge in my acceptance tests?

schulzh commented 2 years ago

Hi @mheath,

I've changed the base branch. It looks like its lagging behind main a few hounded commits. Should I rebase it?

schulzh commented 1 year ago

Hello @mheath,

do you have any updates on this? What is missing to get it merged to master?