cloudfoundry / cf-java-client

Java Client Library for Cloud Foundry
Apache License 2.0
329 stars 317 forks source link

cloudfoundry-client: V3.securitygroups _ListSecurityGroupsRequest extends the wrong pagination request #1242

Open SaifuddinMerchant opened 1 month ago

SaifuddinMerchant commented 1 month ago

Version 3 List Security Groups is extending the wrong version of pagination request import org.cloudfoundry.client.v2.PaginatedRequest;

See _ListSecurityGroupsRequest.java#L17

Error when using the client to make a ListSecurityGroupRequest

org.cloudfoundry.client.v3.ClientV3Exception: CF-UnprocessableEntity(10008): Unknown query parameter(s): 'results-per-page'. Valid parameters are: 'page', 'per_page', 'order_by', 'created_ats', 'updated_ats', 'guids', 'names', 'running_space_guids', 'staging_space_guids', 'globally_enabled_running', 'globally_enabled_staging'
    at org.cloudfoundry.reactor.util.ErrorPayloadMappers.lambda$null$2(ErrorPayloadMappers.java:62)

The generated class ListSecurityGroupsRequest also has the wrong imports, but I am guessing if we fix the import in _ListSecurityGroupsRequest.java that will automatically fix the generated code

CF Java Client Version: 5.12.2.RELEASE CF API version: 3.166.0

Lokowandtg commented 5 days ago

Will look into this.