cloudfoundry / cf-k8s-logging

Apache License 2.0
5 stars 11 forks source link

Set memory and cpu requests and limit values for all containers #34

Closed paulcwarren closed 3 years ago

paulcwarren commented 4 years ago

Relint is currently working on a scaling and Quality of Service (QoS) set of stories.

We are targeting 1.0 to be configured out-of-the-box as a "developer" edition aimed at those users who want to kick the tyres. As part of this, we would like to set limits on mem/cpu.

Since a "developer" edition may not be preferred by everyone, we want each component to be configurable to scale both horizontally (replicas) and vertically (mem/cpu). This will also allow users to deliver a Guaranteed QoS when required (although we are recommending that all of our pods and containers use the Burstable QoS) As part of this we would like to ask you to do several things:

  1. consider which of your pods/containers you would like to expose for scaling properties for.
  2. expose said configuration properties.
  3. sets mem and cpu values for all containers in order to provide as much meta-data to k8s as possible so that its scheduler can do as good a job as possible. This PR is an initial attempt at setting these values, although we know you are much more likely to have insight into your components mem/cpu requirements than our guess.

If you have any questions or concerns, please let us know! Thanks!

#174462927

Co-Authored-By: Carson Long lcarson@vmware.com

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

paulcwarren commented 3 years ago

Hey logging folks, just wanted to ping you on this. Achieving a Burtsable qos is a 1.0 goal for cf-for-k8s and we are approaching 1.0. Is there anything we can do to help this along?

Benjamintf1 commented 3 years ago

@paulcwarren we have to accept and release a bunch of stuff in our backlog, we're working on fixing our integration tests, but making limits and requests on everything is next on our backlog right after that.