search

cloudfoundry / cf-k8s-logging

Apache License 2.0
5 stars 11 forks source link

Remove VirtualService config #47

Closed mike1808 closed 3 years ago

mike1808 commented 3 years ago

Please don't merge this until the PR in cf-for-k8s is merged.

Co-authored-by: Kauana dos Santos kdossantos@vmware.com

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Benjamintf1 commented 3 years ago

@mike1808 any reason this isn't enabled/disabled by flag? might make things easier. We could merge a flagged version whenever, and then flip the flag and add the ingress in cf-for-k8s at the same time.

mike1808 commented 3 years ago

@Benjamintf1 sorry for confusion. We're not going to add a flag because Ingress is going to have the same functionality as VirtualService. We'll work on this after our dev branch in cf-for-k8s is merged.

mike1808 commented 3 years ago

We have this story https://www.pivotaltracker.com/story/show/175359509 for it.

heycait commented 3 years ago

Closing this issue as this has not made it into cf-for-k8s (https://github.com/cloudfoundry/cf-for-k8s/pull/532) and was work to migrate over to Contour that got put down.