search

cloudfoundry / cf-k8s-networking

building a cloud foundry without gorouter....
Apache License 2.0
32 stars 17 forks source link

refactor: update ingress gateway DaemonSet overlay #37

Closed kauana closed 4 years ago

kauana commented 4 years ago

Hey all,

I added a solution to this issue and I would appreciate if y'all took at look at it and let me know what you think. Basically what I am doing is removing the old strategy and replacing it with the updateStrategy + remove maxSurge changes we want.

cc @christianang @XanderStrike @ndhanushkodi @jrussett @tcdowney

tcdowney commented 4 years ago

LGTM

I ran it through kubeval using --strict mode and looks like this is now a bonafide DaemonSet 🎉 !

$ kubeval /tmp/daemonset-ingressgateway.yaml --strict
PASS - /tmp/daemonset-ingressgateway.yaml contains a valid DaemonSet

When ran against the old DaemonSet:

$ kubeval /tmp/daemonset-ingressgateway.yaml --strict
WARN - /tmp/daemonset-ingressgateway.yaml contains an invalid DaemonSet - strategy: Additional property strategy is not allowed

Maybe this is something we could run in CI or as a part of our Istio config generation script to make sure everything remains valid. 🤔

kauana commented 4 years ago

LGTM

I ran it through kubeval using --strict mode and looks like this is now a bonafide DaemonSet !

$ kubeval /tmp/daemonset-ingressgateway.yaml --strict
PASS - /tmp/daemonset-ingressgateway.yaml contains a valid DaemonSet

When ran against the old DaemonSet:

$ kubeval /tmp/daemonset-ingressgateway.yaml --strict
WARN - /tmp/daemonset-ingressgateway.yaml contains an invalid DaemonSet - strategy: Additional property strategy is not allowed

Maybe this is something we could run in CI or as a part of our Istio config generation script to make sure everything remains valid.

Great idea. I will create a chore for that.