search

cloudfoundry / cf-k8s-networking

building a cloud foundry without gorouter....
Apache License 2.0
32 stars 17 forks source link

Update istio build script to use kbld to pin the istio images to digests #41

Closed davewalter closed 4 years ago

davewalter commented 4 years ago

As part of RelInt's work to resolve all image references with digests instead of tags, this PR uses kbld (one of the k14s) to resolve/rewrite the Istio image references in the xxx-generated-istio.yaml.

One unfortunate side-effect of using kbld is that all keys in that file are re-sorted alphabetically, but we feel that this is acceptable as this is an automatically generated file, and this is a one-time thing as it will already be sorted going forward.

Regards, Dave and @acosta11

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172617529

The labels on this github issue will be updated when the story is started.

tcdowney commented 4 years ago

Thanks @davewalter and @acosta11! I've rebased this and resolved the merge conflicts on this branch: https://github.com/cloudfoundry/cf-k8s-networking/tree/davewalter-master

We should be able to merge it once we pick up the story in our backlog.