refactor: extract reconcile logic for Services and VirtualServices

cloudfoundry / cf-k8s-networking

building a cloud foundry without gorouter....

Apache License 2.0

32 stars 17 forks source link

refactor: extract reconcile logic for Services and VirtualServices #42

Closed tcdowney closed 4 years ago

tcdowney commented 4 years ago

I felt like the reconcile logic was getting a little long and hard to follow so I extracted the Service and VirtualService loops into separate helper functions. Also fixed a few places where we were logging without returning the error.

Soloed on this so would appreciate some additional eyes and critique. Thanks!

Done as part of: #171829195

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172632080

The labels on this github issue will be updated when the story is started.