search

cloudfoundry / cf-k8s-networking

building a cloud foundry without gorouter....
Apache License 2.0
32 stars 17 forks source link

inject sidecars for cf-workloads and enable access logs on CI #8

Closed tcdowney closed 5 years ago

tcdowney commented 5 years ago

#169470829

dolfolife commented 5 years ago

why we do not need the gateway anymore? @tcdowney

tcdowney commented 5 years ago

@rodolfo2488 we made it part of the Helm templates in https://github.com/cloudfoundry/cf-k8s-networking/commit/617f569ac562c66f0c53881179f2a6aacd57358d. The one deleted in this commit isn't actually used.

tcdowney commented 5 years ago

We noticed that CATS became flaky after enabling sidecars and apps were returning no healthy upstream from the Envoy sidecar. We saw that the app pods were marked as "ready" when only the sidecar container was running and created an issue with Eirini: https://github.com/cloudfoundry-incubator/eirini/issues/79.

We created a separate story to dig into this more: https://www.pivotaltracker.com/story/show/169685576

Since we don't want to enable sidecar injection globally across our environments until we resolve these issues I think we should definitely split the "sidecar injection enablement" step (that we discussed here) into a separate task that we can selectively apply to dev environments.

I'm going to close this PR as is for now.

cc @ndhanushkodi