search

cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

enable event scheduler #142

Closed Lafunamor closed 7 years ago

Lafunamor commented 7 years ago

This PR allows users to enable the event scheduling feature of mariadb. https://mariadb.com/kb/en/mariadb/events/

cfdreddbot commented 7 years ago

Hey Lafunamor!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/137246355

The labels on this github issue will be updated when the story is started.

robdimsdale commented 7 years ago

This mostly looks fine - one small comment about the default state.

How does one configure this scheduler? I'm mostly asking so we have a conversation here that we can reference if there are questions in the future; we don't need this feature.

One thing we'd like to point out is that it's possible that when you schedule an event, it is executed on all nodes in the cluster, which can lead to some unexpected behavior. You do need the "Process" privilege to do it, so that does limit the scope.

Lafunamor commented 7 years ago

You're right. Default state should be off. I've changed this.

robdimsdale commented 7 years ago

Couple of things that we found with this PR:

yaml maps on and off to boolean values, not strings, which means they come out the other side of our ERB templates as true/false which my.cnf does not accept. We needed to quote the spec default as "off".

The field was in the wrong place in my.cnf - it needed to be moved under [mysqld].