search

cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

Fix quoting in check_mount() #146

Closed alexjh closed 7 years ago

cfdreddbot commented 7 years ago

Hey alexjh!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/138063035

The labels on this github issue will be updated when the story is started.

robdimsdale commented 7 years ago

@alexjh thanks for this. To the best of our ability, we cannot see where this method is used, so rather than merging this PR we'd rather remove this function entirely.

Before we do that, can you tell us if you actually use this function somewhere, or were you just cleaning up quoting because you saw it was potentially a problem?

alexjh commented 7 years ago

This was just a drive-by clean up that I noticed when tracking down something else. :) Removing the function would be fine with me.

robdimsdale commented 7 years ago

Great, thanks. We will remove this function instead of merging this PR.