search

cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

Provide database links for mysql and proxy jobs #154

Closed wendorf closed 7 years ago

wendorf commented 7 years ago

Only expose the IP right now

cfdreddbot commented 7 years ago

Hey wendorf!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/143086033

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 7 years ago

Hey wendorf!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/143629547

The labels on this github issue will be updated when the story is started.

menicosia commented 7 years ago

Just curious, why'd you call them mysql-database instead of just mysql? I assume that's because we're already providing a mysql of type mysql, and you can't provide two links of differing types but the same name?

wendorf commented 7 years ago

Correct, they need to be uniquely addressable by name. I preferred not renaming the original link to something like mysql-internal to reduce the amount of changes (and personal preference) in my PR. If you think a different naming scheme sounds better, please feel free to make that change.