search

cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

Disable running tests when packaging galera #163

Closed mook-as closed 7 years ago

mook-as commented 7 years ago

The tests don't actually give much value (they're more useful when modifying the source code of the package, not when rebuilding known-good source code). Worse, some of the tests are timing-dependent. See also upstream's GALERA_TEST_DETERMINISTIC flag.

Disabling the tests should not affect the output of the build.

cfdreddbot commented 7 years ago

Hey mook-as!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/145631809

The labels on this github issue will be updated when the story is started.

menicosia commented 7 years ago

Thanks @mook-as,

This has been merged and will be made available in the next release. We do see that this saves some time, so thank you!

-- Marco Nicosia Product Manager Pivotal Software, Inc.

menicosia commented 7 years ago

This is now available in cf-mysql-release v36.9.0, thank you for the contribution!

-- Marco Nicosia Product Manager Pivotal Software, Inc.