search

cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

Configureable slow query threshold #185

Closed ldangeard-orange closed 7 years ago

ldangeard-orange commented 7 years ago

To configure slow query threshold, I add a long_query_time property to adjust the value at best. By default, 10s is too long for a transactional type application. The value can be specified to a resolution of microseconds. Slow queries are log in /var/vcap/sys/log/mysql/mysql_slow_query.log.

/CC @axelfauvel @gberche-orange

cfdreddbot commented 7 years ago

Hey ldangeard-orange!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151987215

The labels on this github issue will be updated when the story is started.

menicosia commented 7 years ago

Hi @alexjh @gberche-orange,

Thank you for contributing this!

This suggestion seems to make sense, I've prioritized it for the team to look into merging it soon-ish. (We're currently super occupied with the TLS epic.) They may have some feedback, or wish to do some additional work to make sure it's represented in CI.

-- Marco Nicosia Product Manager Pivotal Software, Inc.

gberche-orange commented 7 years ago

Thanks Marco!

gberche-orange commented 7 years ago

sorry that we overlooked running the unit tests and updating the my.cnf.erb.shasum we'll push new commits to fix this.

/CC @ldangeard-orange

gberche-orange commented 7 years ago

@menicosia BTW, is there a public CI for the mysql (as we would try to run a copy of the cf-mysql-ci prior to submitting our PR) ? I have run into https://core-services.ci.cf-app.com/ but can't see any public pipelines there yet.

jpalermo commented 7 years ago

Hey @gberche-orange. Currently the CI is not public. cf-mysql-ci is open source, although the amount of infrastructure and setup needed to get it up and running would probably make it prohibitive to run the pipelines yourself.

(https://github.com/cloudfoundry-incubator/cf-mysql-ci) is more intended as a demonstration of how we run tests, and possibly some of the scripts in there are useful if you try to implement tests of your own.

gberche-orange commented 7 years ago

thanks @jpalermo for this clarification.

gberche-orange commented 7 years ago

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@ldangeard-orange is now covered by Orange CCLA as a public member of https://github.com/orange-cloudfoundry . Should be fine to retrigger the dreddbot by closing & reopening this issue.

menicosia commented 7 years ago

@ldangeard-orange @gberche-orange this will be included in v36.10.0

gberche-orange commented 7 years ago

thanks @menicosia and core services team!