cloudfoundry / cf-mysql-release

Cloud Foundry MySQL Release
Apache License 2.0
58 stars 106 forks source link

add performance_schema property #190

Closed ldangeard-orange closed 6 years ago

ldangeard-orange commented 7 years ago

This PR optionally enables operators to enable performance_schema feature in MariaDB. This requires setting the cf_mysql.mysql.performance_schema_enabled property to true in mysql instance group (default is false)

In MariaDB distribution , by default performance_schema is OFF since 10.0.12. See doc performance_schema

The performance_schema instrument flags (e.g. performance_schema_max_file_handles) are given sensible defaults based on Orange production usage (which sometimes slightly differ from mariadb defaults). Documentation mentions possible memory impact of turning on the feature and ways to measure it.

Background

The Performance Schema is a feature for monitoring server performance, see related mariadb documentation.

Performance_schema database, consists of a number of tables that can be queried with regular SQL statements, returning specific performance information.

Numerous community monitoring tools leverage the Performance Schema feature, such as :

This PR replaces #188

cfdreddbot commented 7 years ago

Hey ldangeard-orange!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152670917

The labels on this github issue will be updated when the story is started.

gberche-orange commented 7 years ago

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

@ldangeard-orange is now covered by Orange CCLA as a public member of https://github.com/orange-cloudfoundry . Should be fine to retrigger the dreddbot by closing & reopening this issue.

gberche-orange commented 6 years ago

@menicosia any update on handling of this pr ?

gberche-orange commented 6 years ago

@menicosia any update on handling of this pr ?

ldangeard-orange commented 6 years ago

New PR