search

cloudfoundry / cf-uaac

Apache License 2.0
41 stars 29 forks source link

Missing parameter required_user_groups for client #126

Closed cache-sk closed 10 months ago

cache-sk commented 11 months ago

Cant set "required_user_groups" for client via uaac client update [id], there is no such parameter as --required_user_groups.

Also, uaac clients and uaac client get [id] not showing required_user_groups at all, only result after update shows it.

Using UAA client 4.17.0 installed / updated via gem.

cf-gitbot commented 11 months ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

bruce-ricard commented 10 months ago

This is a feature request.

The required_user_groups were added to the UAA server in 2017. It was never added to the uaac.

Thank you for noticing that @cache-sk . We won't have the bandwidth to implement it. But if you really need it, and you are willing to implement it and send a PR, we'll be happy to review it and merge it.

cache-sk commented 10 months ago

@bruce-ricard Well, this is my first encounter with ruby, but i think i handled it.

cf-gitbot commented 10 months ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

strehle commented 10 months ago

reopen because we have a PR

strehle commented 10 months ago

@bruce-ricard @hsinn0 Created also a PR where tests are , so fix is in https://github.com/cloudfoundry/cf-uaac/pull/127 and some test in my PR