search

cloudfoundry / cf-uaac

Apache License 2.0
41 stars 29 forks source link

Support ca_file for http client in curl mode #130

Closed strehle closed 11 months ago

strehle commented 11 months ago

With curl simulation mode the parameters from curl needs to be passed The parameters from uaac target xxx are not used here.

Therefore, ca cert was missing. -b for --skip-ssl-validation is available

For uaac target --ca-cert there is was no setting.

Added -C or --cacert because these are the parameters from curl

cf-gitbot commented 11 months ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

strehle commented 11 months ago

@beyhan Added you because this issue causes problems so that I would like to release uaac but also dont want break the cross company rules (about review) so that you and @rkoster should judge, can I merge and release ?

beyhan commented 11 months ago

The change looks straight forward to me. Best would be if this could be coordinated in the UAA area itself. My observation is that the cooperation in the UAA area works good.

strehle commented 11 months ago

f. My observation is that the cooperation in the UAA area works good.

Yes sure, the problem is that if there is an escalation then we need to have a new release in a very short time and for this I ask for your approval.

The cross company reviews work, so I asked you not because I dont get a review from VMware colleagues, but because of an SAP internal escalation

Tallicia commented 11 months ago

Feel free to go ahead and merge this or indicate if it's ok for us to merge.