search

cloudfoundry / cf-uaac

Apache License 2.0
41 stars 29 forks source link

uaac does not apply env var https_proxy to https targets (but http_proxy) #49

Closed heikoettelbruecksap closed 6 years ago

heikoettelbruecksap commented 6 years ago

Following the typical convention for environment variables for proxy servers on Linux, and with UAA being available on an HTTPS URL, I set https_proxy to the respective proxy server URL. Still I realized the connection from uaac to UAA failed, and looking at network traffic, I realized it's because uaac still tried to connect directly to UAA, not via the proxy. Trying to set http_proxy to the same value finally made the connection work, so it seems like uaac does support proxies, but always expects the proxy to be configured in http_proxy, regardless of whether the target is an HTTP or HTTPS URL. From my point of view, it would be good to follow the usual conventions and evaluate either one or the other environment variable depending on the protocol of the target URL. Maybe you can have a fallback to keep compatibility by choosing http_proxy if https_proxy is not set.

cf-gitbot commented 6 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155059779

The labels on this github issue will be updated when the story is started.

sreetummidi commented 6 years ago

@heikoettelbruecksap We don't have plans to add this support to UAAC at this time. UAA supports server side proxy set up using the same env variables