search

cloudfoundry / cf-uaac

Apache License 2.0
41 stars 29 forks source link

Ruby 3 support #95

Closed bgandon closed 2 years ago

bgandon commented 2 years ago

Along with cloudfoundry/cf-uaa-lib#73, this PR brings Ruby 3 support in cf-uaac.

Unit tests have successfully run on my laptop with Ruby 2.7.2, 3.0.2, and 3.1.0.

I haven't run them in a CI pipeline with fresh set of gem dependencies, and I haven't run the integration tests yet. I'll update the status once this is done.

cf-gitbot commented 2 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/180846284

The labels on this github issue will be updated when the story is started.

strehle commented 2 years ago

here I cannot merge because continuous-integration/travis-ci is not runnig @rkoster I cannot change travis pipeline thus I am not admin in this project so either remove travis or change from org to https://app.travis-ci.com/github/cloudfoundry/cf-uaac -> press migrate (only for admins)

strehle commented 2 years ago

@bgandon we now ready to rebase and your PR should get green now also with ruby 3.x , please rebase now

bgandon commented 2 years ago

I've rebased the branch on top of new master branch. It's ready to be merged.

bgandon commented 2 years ago

Nice, thank you Markus! 👍