cloudfoundry / cli

The official command line client for Cloud Foundry
https://docs.cloudfoundry.org/cf-cli
Apache License 2.0
1.75k stars 929 forks source link

`cf v3-set-health-check` command also sets `command` even when not specified #1772

Open selzoc opened 5 years ago

selzoc commented 5 years ago

Please fill out the issue checklist below and provide ALL the requested information.

Describe the bug and the command you saw an issue with Setting a healthcheck should not modify the command field on a process. Once the command is set via an API call, it can't be modified by buildpacks in future pushes.

In particular, there is a user that wants to set the invocation-timeout but does not want the command to be set so that they can pick up new commands out of newer java buildpack versions.

What happened command is set to the detected start command

Expected behavior command remains null

To Reproduce Steps to reproduce the behavior; include the exact CLI commands and verbose output:

  1. Run cf push app-name
  2. Run cf curl /v2/apps/$(cf app app-name --guid) | jq .entity.command This is null.
  3. Now update the health-check with cf v3-set-healthcheck app-name port
  4. Run cf curl /v2/apps/$(cf app app-name --guid) | jq .entity.command This is not null, it seems to be set to the detected start command.

Provide more context

Note: As of January 2019, we no longer support API versions older than CF Release v284/CF Deployment v1.7.0 (CAPI Release: 1.46.0 (APIs 2.100.0 and 3.35.0).

Note: In order to complete the v7 beta cf CLI in a timely matter, we develop and test against the latest CAPI release candidate. When v7 cf CLI is generally available, we will start supporting official CC API releases again.

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/168224517

The labels on this github issue will be updated when the story is started.

abbyachau commented 5 years ago

Hey @selzoc many thanks for this. Do you know if this is an issue on v7 beta? Our plan, since all these prefixed commands are experimental, is to update the v7 command and ask users to use v7 beta instead for v3 commands we've already converted over. Let us know though if there are considerations, we know that since these prefixed commands have been on the cf CLI for so long now, there might be a class of issues for prefixed commands that we might need to address. Thanks.

selzoc commented 5 years ago

No, it does not happen with the cf7 beta, at least version 7.0.0-beta.24+71d763254.2019-08-20

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed.