search

cloudfoundry / cli

The official command line client for Cloud Foundry
https://docs.cloudfoundry.org/cf-cli
Apache License 2.0
1.75k stars 928 forks source link

Fix pr issues #2968

Closed joaopapereira closed 1 month ago

joaopapereira commented 1 month ago

Description of the Change

Fix github action failing while testing PRs. We found out that when we were using workflow_run, we were always retrieving the workflow files from the main branch. The main change that is made here is to stop relying on workflow_run and to call the integration tests after the unit tests are successful.

a-b commented 1 month ago

The integration tests workflow was designed in that specific way to enable PRs from forks to run integration tests using repository secrets containing credentials for the Shepherd. It also requires approval to run tests for new contributors, which helps maintain security for sensitive information.

Do we know if the proposed change operates in the equivalent way?

joaopapereira commented 1 month ago

The only change this PR introduces is how the integration tests are triggered. Instead of using a "global" trigger, each workflow explicitly runs the integration tests, which is the only change.