search

cloudfoundry / cli

The official command line client for Cloud Foundry
https://docs.cloudfoundry.org/cf-cli
Apache License 2.0
1.75k stars 929 forks source link

Possibility to disable manifest diff. #3271

Open krismarc opened 3 weeks ago

krismarc commented 3 weeks ago

Hi there,

after migration from v7 to v8, I've noticed introduction of manifest diff. Would be nice to have an option to disable it with an env var or so or at least prevent it's output from being passed to stdout.

https://github.com/cloudfoundry/cli/blob/fb9397c4a5db4a1ea4905ce4496e8b524794b40f/command/v7/push_command.go#L209 https://github.com/cloudfoundry/cli/blob/fb9397c4a5db4a1ea4905ce4496e8b524794b40f/command/v7/apply_manifest_command.go#L108

..some conditional skip would need to be present here.

Reasoning behind it. I know envs are not supposed to be used to treat sensitive info. However, if somebody does that, it would be nice to have an option to at least disable it from the default push output. As it wasn't present before in v7.

Best regards, K.M.

gururajsh commented 2 weeks ago

Thank you for your submission. Will discuss this with the team and update here.