cloudfoundry / cloud_controller_ng

Cloud Foundry Cloud Controller
Apache License 2.0
191 stars 357 forks source link

CC API V3 site redirections loose fragments #1329

Closed gberche-orange closed 5 years ago

gberche-orange commented 5 years ago

Issue

http://v3-apidocs.cloudfoundry.org/index.html#metadata redirects to http://v3-apidocs.cloudfoundry.org/version/3.69.0/index.html (i.e. without the fragment to the subsection)

Context

As an API user, in order to add deep permalinks to the latest api version (e.g. in specs such as https://github.com/openservicebrokerapi/servicebroker/blob/master/profile.md#cloud-foundry-context-object), I need the api website redirects to preserve fragments in the original url. See https://stackoverflow.com/a/2305927 for related http specifications .

Steps to Reproduce

open in web browser http://v3-apidocs.cloudfoundry.org/index.html#metadata

Expected result

http://v3-apidocs.cloudfoundry.org/index.html#metadata redirects to http://v3-apidocs.cloudfoundry.org/version/3.69.0/index.html#metadata

Current result

http://v3-apidocs.cloudfoundry.org/index.html#metadata redirects to http://v3-apidocs.cloudfoundry.org/version/3.69.0/index.html (i.e. without the fragment to the subsection)

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/165562824

The labels on this github issue will be updated when the story is started.

reidmit commented 5 years ago

Hi @gberche-orange, we have fixed this. As of yesterday, the URL hash is now preserved when redirecting. I'm going to close this, but feel free to reopen if you have more problems with it.

cc @selzoc

gberche-orange commented 5 years ago

great, thanks @reid47 and @selzoc !