Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
The rotate database key tests for unencrypted fields check for the presence of values only which excludes model instances with nil values. We propose to exclude all columns with nil values from this check.
An explanation of the use cases your change solves
We want to introduce a new foreign key cnb_lifecycle_data in buildpack_lifecycle_buildpack_model which could be nil. This test prevents the check to pass.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change: The rotate database key tests for unencrypted fields check for the presence of values only which excludes model instances with nil values. We propose to exclude all columns with nil values from this check.
An explanation of the use cases your change solves We want to introduce a new foreign key cnb_lifecycle_data in buildpack_lifecycle_buildpack_model which could be nil. This test prevents the check to pass.
Links to any other associated PRs https://github.com/cloudfoundry/cloud_controller_ng/pull/3778
[x] I have reviewed the contributing guide
[x] I have viewed, signed, and submitted the Contributor License Agreement
[x] I have made this pull request to the
mainbranch[x] I have run all the unit tests using
bundle exec rake[ ] I have run CF Acceptance Tests