cloudfoundry / cloud_controller_ng

Cloud Foundry Cloud Controller
Apache License 2.0
187 stars 356 forks source link

JSON encode values in SCIM filter string #3839

Closed philippthun closed 1 month ago

philippthun commented 1 month ago

When building the SCIM filter string, all values (e.g. user ids, names) are now JSON encoded (*), i.e. #{Oj.dump(str)} instead of "#{str}".

Furthermore when receiving a TargetError, the 'error_info' (i.e. JSON response from UAA containing error details) is now logged.

(*) Excerpt from RFC7644:

SCIM filters MUST conform to the following ABNF [...] rules as specified below:

[...]

compValue = false / null / true / number / string; rules from JSON (RFC 7159)

[...]

In the above ABNF rules, the "compValue" (comparison value) rule is built on JSON Data Interchange format ABNF rules as specified in [RFC7159] [...]