allow empty files and ensure that we fail on invalid files

cloudfoundry / credhub-cli

CredHub CLI provides a command line interface to interact with CredHub servers

Apache License 2.0

39 stars 44 forks source link

allow empty files and ensure that we fail on invalid files #76

Closed jpmcb closed 5 years ago

jpmcb commented 5 years ago

Signed-off-by: John Cornish jcornish@pivotal.io

Resolves issue #75.

Tested the new workflow with a built binary:

→ credhub interpolate --file minimal-yaml.yml
null

→ echo $?
0

→ credhub interpolate --file invalid-yaml.yml
yaml: invalid map key: ...

→ echo $?
1

→ credhub interpolate --file empty-yaml.yml

→ echo $?
0

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/166335247

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 5 years ago

:white_check_mark: Hey jpmcb! The commit authors and yourself have already signed the CLA.

ankeesler commented 5 years ago

Release https://github.com/cloudfoundry-incubator/credhub-cli/releases/tag/2.5.0 has a fix for this. Sorry again about the miscommunication.