search

cloudfoundry / diego-release

BOSH Release for Diego
Apache License 2.0
201 stars 213 forks source link

Make max-containers setting configurable #867

Closed petrinski closed 7 months ago

petrinski commented 9 months ago

Summary

diego-release/jobs/rep/templates/setup_mounted_data_dirs.erb This file contains a hardcoded line where the containers are set to 250. It is used to estimate the size of a file system for certificates. Currently, in our case, on cells with 250 containers, only 60% of the size are used, so we can freely increase them.

Diego repo

https://github.com/cloudfoundry/rep https://github.com/cloudfoundry/garden-runc-release

PlamenDoychev commented 9 months ago

PRs:

garden-runc: https://github.com/cloudfoundry/garden-runc-release/pull/314 diego-release: https://github.com/cloudfoundry/diego-release/pull/868

MarcPaquette commented 9 months ago

Hi @PlamenDoychev I've merged both PR's for this issue. Thanks for the contributions! Thanks again, @MarcPaquette

PlamenDoychev commented 9 months ago

Thanks @MarcPaquette!

MarcPaquette commented 8 months ago

Reopening this issue as it's causing some issues down the line. More details to follow.

MarcPaquette commented 8 months ago

Reverting these two PR's (garden-runc: https://github.com/cloudfoundry/garden-runc-release/pull/314 diego-release: https://github.com/cloudfoundry/diego-release/pull/868) as they causing some issues with cf-deployment.

MarcPaquette commented 8 months ago

Revert PR's: https://github.com/cloudfoundry/diego-release/pull/873 https://github.com/cloudfoundry/garden-runc-release/pull/327

klapkov commented 8 months ago

More info on why the PR's were reverted and why the bosh link was removed can be found here: https://cloudfoundry.slack.com/archives/C02FM2BPE/p1702069406637829

Thanks for the support.