Update local testing scripts for launching a local docker container

cloudfoundry / diego-release

BOSH Release for Diego

Apache License 2.0

201 stars 212 forks source link

Update local testing scripts for launching a local docker container #916

Closed geofffranks closed 7 months ago

geofffranks commented 7 months ago

Thank you for submitting a pull request to the diego-release repository. We appreciate the contribution. To help us with getting better context for the pull request please follow these guidelines:

Please make sure to complete the following steps

[ ] Before PR Submission, Submit an issue for either an Enhancement or Bug
[ ] Check the Contributing document on how to sign the CLA and run tests in diego-release.
[ ] Make sure a pull request is done against the develop branch.

Issue Link

Please link the issue you created above for a bug or enhancement.

Thank you!

winkingturtle-vmw commented 7 months ago

I am sure if I followed what wasn't working before or how it stopped working. It'd be good to know what prompted this change.

geofffranks commented 7 months ago

These changes were to get the ability to launch docker locally for testing - so that we can test smaller changes interactively or via ginkgo watch, rather than the full test suite.

winkingturtle-vmw commented 7 months ago

I thought we could run a subset of tests using /repo/scripts/docker/test.bash <PACKAGE> <SUB_PACKAGE> from within the container. Did it not work or was there a need for more?

As for ginkgo watch (I don't think I've ever ran it before), but did we try modifying FLAGS env variable? I think that would also accomplish the forever running of the tests.