search

cloudfoundry / diego-windows-release

Apache License 2.0
9 stars 13 forks source link

Rep TLS config is hard coded #22

Closed amhuber closed 7 years ago

amhuber commented 7 years ago

When the rep config was changed to pull from a file it's now using hard coded values for the TLS configuration:

https://github.com/cloudfoundry/diego-windows-release/blob/master/DiegoWindowsRelease/RepService/RepService.cs#L42-L45

It was previously pulling from the provided values:

https://github.com/cloudfoundry/diego-windows-release/blob/12830d1a97fa6bf30ec9490693f5fc6d98f0d58b/DiegoWindowsRelease/RepService/RepService.cs#L93-L96

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/137242391

The labels on this github issue will be updated when the story is started.

mhoran commented 7 years ago

See the following commit for the changes: https://github.com/cloudfoundry/diego-windows-release/commit/c0c2eefaa055060a53fa8a95ef1f52c27ff5427a