search

cloudfoundry / docs-buildpacks

http://docs.cloudfoundry.org/buildpacks/
Apache License 2.0
21 stars 118 forks source link

Confusing #233

Closed aglwallac closed 3 years ago

aglwallac commented 5 years ago

in within: docs-buildpacks/node/index.html.md.erb Lines 120-124?

When vendoring apps for usage in offline environments, you must supply a lock file. For information about npm lockfiles, see npm-package-locks in the NPM documentation. For information about the NPM lock file, see package-lock.json in the NPM documentation.

Unsure of double reference to npm lock files. Maybe clarity in this sentence is needed.

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

mjgutermuth commented 3 years ago

Hi! It looks like this issue was addressed here: https://github.com/cloudfoundry/docs-buildpacks/commit/f566735726f02cb44f21b435c3b7e4ed03f21ccd

Thank you!