cloudfoundry / docs-buildpacks

http://docs.cloudfoundry.org/buildpacks/
Apache License 2.0
21 stars 118 forks source link

Update Staticfile location instructions #245

Closed meganmajewski closed 5 years ago

meganmajewski commented 5 years ago

The Staticfile location instructions were unclear in telling users to place the file at the root because root directory implies root of the repository. On further investigation this really means in the build directory. See this issue for more information - it instructs users to place the Staticfile in the build directory also: https://github.com/cloudfoundry/staticfile-buildpack/issues/148

cfdreddbot commented 5 years ago

:x: Hey meganmajewski!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @meganmajewski is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

mlimonczenko commented 5 years ago

Thank you, @meganmajewski, for your contribution. I need the CLA signed in order to merge, so I made the commit myself.

Once you sign the CLA successfully, the bot will tell me that your future PRs are safe to merge.