cloudfoundry / docs-buildpacks

http://docs.cloudfoundry.org/buildpacks/
Apache License 2.0
21 stars 118 forks source link

Non-binary needs to be "all" not "none" #267

Closed mmessmore closed 4 years ago

mmessmore commented 4 years ago

The command's logic was the inverse of the explanation below.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

jncd commented 4 years ago

Hi @mmessmore Thanks for your PR. Apparently, the command is correct as stands. I've been referred to https://github.com/cloudfoundry/docs-buildpacks/issues/259 and to --no-binary=:none:. I'm going to adjust the comment text above the command to read: # vendors pip *.tar.gz into vendor/ instead of # vendors all the pip *.tar.gz into vendor/ Good to get rid of the misleading "all". The * should be enough to indicate all, I think.