Closed 7ochem closed 3 years ago
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.
The labels on this github issue will be updated when the story is started.
Hi @7ochem Thank you for this Pull Request. For us to accept it, we must have a Contributor License Agreement (CLA) on file with us. We cannot accept PRs from people who are not covered by a CLA.
If you decline to sign a CLA, we're happy to use the information that you've provided to update the documentation, but we'll have to do it without accepting your PR.
Hi @7ochem Thank you for this Pull Request. For us to accept it, we must have a Contributor License Agreement (CLA) on file with us. We cannot accept PRs from people who are not covered by a CLA.
If you decline to sign a CLA, we're happy to use the information that you've provided to update the documentation, but we'll have to do it without accepting your PR.
Hi @animatedmax I have signed the Contributor License Agreement (CLA).
Thank you @7ochem !
Changed the COMPOSER_INSTALL_OPTIONS defaults to show this is a "list" (a JSON array)
This fixes part of https://github.com/cloudfoundry/php-buildpack/issues/309 where one of the reported issues is that, if you make this a string, then the composer install command would become:
composer install - - n o - i n t e r a c t i o n - - n o - d e v - - n o - p r o g r e s s
. This is what happened to me too and I have been searching for quite a while for what could be the problem and what could be the solution. If the default in the docs shows a list, then it will be much clearer to its readers that they should add this to the options.json as a list.