Add HTTP/2 configuration to Staticfile docs

cloudfoundry / docs-buildpacks

http://docs.cloudfoundry.org/buildpacks/

Apache License 2.0

21 stars 118 forks source link

Add HTTP/2 configuration to Staticfile docs #282

Closed Gerg closed 2 years ago

Gerg commented 2 years ago

Implementation PR: https://github.com/cloudfoundry/staticfile-buildpack/pull/254

[cloudfoundry/routing-release#200]

cc @robdimsdale

cf-gitbot commented 2 years ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

robdimsdale commented 2 years ago

Hey, this looks good in principle. I haven't actually run it through the docs generator to see if it renders properly.

Separately, I want to wait for the buildpack to be released before merging the docs so they don't end up going public too soon.

robdimsdale commented 2 years ago

cc @menehune23

mjgutermuth commented 2 years ago

Thanks @Gerg! I just saw your note above @robdimsdale --is this ready to merge? If not, I can revert. Thanks!

menehune23 commented 2 years ago

@mjgutermuth My understanding is that it was safe to merge. Correct me if I'm wrong @robdimsdale

robdimsdale commented 2 years ago

Should be fine. I was waiting until we shipped the buildpack before merging the notes so they didn't describe a feature that hadn't shipped yet. We shipped the buildpack so the notes are good to go. Thanks for checking @mjgutermuth !