Fix incorrect microbosh manifest.

[benjsmi]

I have tried many many times to get the YAML right using this manifest and it never seems to succeed. My solution has always been to delete the lines shown here. Then everything works OK.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: http://www.pivotaltracker.com/story/show/68535776

[araher]

Hello Sam,

First of all, you're correct about the spacing in line 126 (the recursor entry). Thanks for that! I have committed that change on my own. I've also changed the logging level to debug, which we recommend in general.

About your suggested changes in the cloud block:

I shared this with the BOSH team, and they're not sure why you're unable to deploy with the NTP server specified in the manifest. Manifests we've tested do work correctly with the NTP lines in there.

Similarly, we're not sure why you would flatten out the spacing of the datacenters sub-block. Manifests we've tested have the spacing shown in the doc.

Could you possibly share the following with us?

1. The command you're using to deploy MicroBOSH, along with the output.
2. When the deployment ends (including when it fails), you'll see a task ID. Run this command... bosh --debug ...and send us the debug output.

Thanks much!

Abe

[benjsmi]

Actually, it's not an issue with deployment; it's an issue with the YAML. There are no problems with NTP, there are issues with the "agent" object within the YAML descriptor. Below is a shell session that demonstrates the problem. I used the YAML that can be found http://docs.cloudfoundry.org/deploying/vsphere/deploying_micro_bosh.html There and simply filled in the values for my environment.

programsam@cf-goofy:~/bosh-workspace/microbosh$ cat microbosh-test.yml
---
name: MicroBOSH01

network:
  ip: 9.37.193.197
  netmask: 255.255.255.0
  gateway: 9.37.193.1
  dns:
  # The micro-bosh VM has the following DNS entries in its /etc/resolv.com, allowing it to resolve, for example, IaaS FQDNs.
  - 9.42.106.2
  cloud_properties:
    name: VLAN228

resources: # this seems like good sizing for microbosh
   persistent_disk: 16384
   cloud_properties:
      ram: 8192
      disk: 16384
      cpu: 4
cloud:
  plugin: vsphere
  properties:
    agent:
      ntp:
      - 0.north-america.pool.ntp.org
      - 1.north-america.pool.ntp.org
     vcenters:
       - host: *******
         user: *******
         password: *******
         datacenters:
           - name: "HaaS ICAP"
             vm_folder: bosh-vms-039
             template_folder: bosh-templates-039
             disk_path: mydisk
             datastore_pattern: visidpx039-storage
             persistent_datastore_pattern: visidpx039-storage
             allow_mixed_datastores: true
             clusters:
             - "HaaS ICAP039"

apply_spec:
  properties:
    vcenter:
      host: *****
      user: *******
      password: ********
      datacenters:
        - name: "HaaS ICAP"
          vm_folder: bosh-vms-039
          template_folder: bosh-templates-039
          disk_path: mydisk
          datastore_pattern: visidpx039_storage
          persistent_datastore_pattern: visidpx039_storage
          allow_mixed_datastores: true
          clusters:
          - "HaaS ICAP039"
    dns:
        # The BOSH powerDNS contacts the following DNS server for serving DNS entries from other domains.
        recursor: 9.42.106.2

logging:
  # If needed increase the default logging level to trace REST traffic with IaaS providers. Default is info
  level: info
  # Default location is <deployment_dir>/bosh_micro_deploy.log
  # file :

programsam@cf-goofy:~/bosh-workspace/microbosh$ bosh micro deployment ./microbosh-test.yml
/home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/1.9.1/psych.rb:203:in `parse': (<unknown>): did not find expected key while parsing a block mapping at line 23 column 5 (Psych::SyntaxError)
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/1.9.1/psych.rb:203:in `parse_stream'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/1.9.1/psych.rb:151:in `parse'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli-1.2175.0/lib/cli/yaml_helper.rb:48:in `check_duplicate_keys'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli-1.2175.0/lib/cli/core_ext.rb:78:in `load_yaml_file'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli_plugin_micro-1.2175.0/lib/bosh/cli/commands/micro.rb:46:in `set_current'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli_plugin_micro-1.2175.0/lib/bosh/cli/commands/micro.rb:32:in `micro_deployment'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli-1.2175.0/lib/cli/command_handler.rb:57:in `run'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli-1.2175.0/lib/cli/runner.rb:56:in `run'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli-1.2175.0/lib/cli/runner.rb:16:in `run'
    from /home/programsam/.rbenv/versions/1.9.3-p484/lib/ruby/gems/1.9.1/gems/bosh_cli-1.2175.0/bin/bosh:7:in `<top (required)>'
    from /home/programsam/.rbenv/versions/1.9.3-p484/bin/bosh:23:in `load'
    from /home/programsam/.rbenv/versions/1.9.3-p484/bin/bosh:23:in `<main>'
programsam@cf-goofy:~/bosh-workspace/microbosh$ bosh --version
BOSH 1.2175.0

[araher]

Hello Sam,

We've now corrected spacing at several points in the example manifest. The blow-up you were seeing was caused, we think, by an extra space before the vcenters sub-block (it should be a peer to the agent sub-block above it).

The corrected example will be pushed to production shortly. I'll close this PR in the meantime.

Thanks again for pointing out the problem!

best, Abe