search

cloudfoundry / docs-deploying-cf

The docs repo for material on deploying Cloud Foundry
Apache License 2.0
15 stars 101 forks source link

remove misleading comment about consul creds, and fix code rendering #85

Closed Amit-PivotalLabs closed 8 years ago

cfdreddbot commented 8 years ago

Hey Amit-PivotalLabs!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/114645431.

pspinrad commented 8 years ago

Thanks Amit!

Amit-PivotalLabs commented 8 years ago

@pspinrad yes, is that a problem?

I noticed your next commit just reverted this change. This change fixed two things:

  1. <code>generate_deployment_manifest ... is not correct, it should say <code>$ ./scripts/generate_deployment_manifest ...
  2. In the <code> tag, the generate_deployment_manifest underscores have the undesirable effect of italicizing "deployment", and the underscores themselves disappear. Switching to <pre> tags fix this, but as you noticed, move it out of the note.

If we can get the code snippet inside the note, that's ideal, but I'd definitely want the issues I just mentioned above fixed.