cloudfoundry / docs-dev-guide

Documentation for application developers who want to deploy their applications to Cloud Foundry
Apache License 2.0
39 stars 217 forks source link

Improve health check timeout documentation #470

Open beyhan opened 1 year ago

beyhan commented 1 year ago

Improve the health checks timeout section with more specific information about how to set it. At the moment the CF CLI doesn't support health check timeout configuration as described in this issue and users get confused with the --invocation-timeout option supported by the CF CLI. I'm suggesting to make it more clear how the timeout could be configured via CF CLI and CF APIs.

cf-gitbot commented 1 year ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

anita-flegg commented 1 year ago

@Gerg , do you have any suggestions for how to do this correctly? Thanks :)

beyhan commented 1 year ago

My suggestion is: Is it by intention that cf set-health-check shouldn't support the timeout configuration because it is relevant when pushing an app? If yes, we can just put a note that it should be configured during push with cf push -t or in the manifest and set-health-check doesn't support it.

anita-flegg commented 10 months ago

@beyhan , have you had any update on this?

beyhan commented 10 months ago

Hi @anita-flegg,

I didn't get any feedback on the CLI issue but I will create in the next days a pr for the docs to add more details about this at least.

anita-flegg commented 10 months ago

Thanks, @beyhan