cloudfoundry / dotnet-core-buildpack

Cloud Foundry buildpack for .NET Core on Linux
http://docs.cloudfoundry.org/buildpacks/
Apache License 2.0
91 stars 90 forks source link

Rename Buildpack? #43

Closed joefitzgerald closed 8 years ago

joefitzgerald commented 8 years ago

Because ASP.NET 5 !== what this is anymore...

Potential name options:

joefitzgerald commented 8 years ago

Why couldn't this also run console apps?

joefitzgerald commented 8 years ago

By not supplying core you run the risk of someone thinking this might apply to legacy .NET, or some kind of legacy mono app.

Using that line of reasoning we should have a java-8-buildpack to avoid confusion that it does not run 1.4 apps.

joefitzgerald commented 8 years ago

Apps can be started with --no-route and work against a message broker (e.g. RabbitMQ).

autodidaddict commented 8 years ago

I vote for dotnet-core-buildpack

samanthacooper11 commented 8 years ago

I vote for dotnet-core-buildpack

itzunagi commented 8 years ago

Technically the buildpack does pass a parameter to kestrel through the command-line right now giving it a server-urls parameter, this is something specific to a web app. Even with that parameter being passed, console apps could still run but they would receive those parameters from the command-line.

joefitzgerald commented 8 years ago

@degrim noted. I suppose the question isn't so much the current state, but what the buildpack aspires to be? I think it should allow apps to start with or without a (HTTP/S) route, particularly given future TCP routing capabilities.

itzunagi commented 8 years ago

@joefitzgerald I think before the changes in RC2 to use the .Net CLI, it didn't make sense for this buildpack to also try to support console apps. But now that ASP.Net Core runs on top of the same CLI as .Net Core console apps, it makes a little more sense to accommodate this scenario as well.

itzunagi commented 8 years ago

Using that line of reasoning we should have a java-8-buildpack to avoid confusion that it does not run 1.4 apps.

That's not entirely true, this buildpack supports ASP.Net Core (and now .Net Core console apps?) which is a different product than ASP.Net and Classic ASP. ASP.Net 1.0 released in 2002, ASP.Net Core 1.0 releases later this year.

joefitzgerald commented 8 years ago

@degrim yes, @autodidaddict and I hashed it out via Slack and I agree - core should be part of the name.

itzunagi commented 8 years ago

Console apps do indeed work with --no-route, so my vote would be for dotnet-core-buildpack.

opiethehokie commented 8 years ago

buildpack renamed

joefitzgerald commented 8 years ago

🎉