search

cloudfoundry / eirini-controller

Apache License 2.0
1 stars 1 forks source link

Interpret memory and disk storage as mebibytes #20

Closed clintyoshimura closed 2 years ago

clintyoshimura commented 2 years ago

@gcapizzi @julian-hj

clintyoshimura commented 2 years ago

Is there a way to run the integration/eats tests? We were able to run the unit tests, but the integration and eats tests seem to need an eirini/docker-hub pass entry.

kieron-dev commented 2 years ago

Is there a way to run the integration/eats tests? We were able to run the unit tests, but the integration and eats tests seem to need an eirini/docker-hub pass entry.

The workaround for integration tests is to set EIRINIUSER_PASSWORD to '', i.e.

EIRINIUSER_PASSWORD= ./scripts/check-everything.sh -i

This just means you skip the tests for private registry images.

For EATS, we need to do something about sideloading the image from kbld into kind. We're having a look at this now.

kieron-dev commented 2 years ago

We've just pushed a change to the script so you don't need docker hub credentials for running EATS either.

Again, you need to set EIRINIUSER_PASSWORD to empty to skip the private registry tests. I.e.

EIRINIUSER_PASSWORD= ./scripts/check-everything.sh -e

So rebase on master, and you'll be able to do this.

kieron-dev commented 2 years ago

By the way, there is an integration test failure. Could you look at it please?


• Failure [1.398 seconds]
Desire when the the app has sidecars [It] sets resource limits on the sidecar container
/usr/src/app/tests/integration/k8s/stset/desire_test.go:261

  Expected
      <int64>: 105906176
  to equal
      <int64>: 101000000

  /usr/src/app/tests/integration/k8s/stset/desire_test.go:241
------------------------------
clintyoshimura commented 2 years ago

Thanks for making those options available. After rebasing with main I was able to get past the docker-hub pass error I was getting before. Unfortunately, I've run into some other errors with kind, docker, and telepresence on my mac dev env. With the newest telepresence it just ends without any output or logs. With the older one, it runs but eventually all the integration tests fail with connection errors. I'm not sure it's program versions or security policies on my mac or something else. I made a speculative fix for the desire_test.go listed above, but unfortunately I still can't run it to verify. Are there any CICD pipelines that can be run on PRs to verify or existing dev envs I could verify on?