search

cloudfoundry / eirini-release

Helm release for Project Eirini
Apache License 2.0
36 stars 34 forks source link

The LRP CRD definition in eirini-release is out of sync with the eiriniv1.LRP type #212

Closed kieron-dev closed 3 years ago

kieron-dev commented 3 years ago

In the CRD, status looks like: 

status:
  type: object
  properties:
    replicas:
      type: integer
    instances:
      type: array
      items:
        type: object
        properties:
          since:
            type: integer
            format: uint64
          index:
            type: integer
            format: uint32
          state:
            type: string
            enum:
            - Pending
            - Running
            - Failed
            default: Pending
          exitStatus:
            type: integer
            format: uint32
          exitReason:
            type: string
          crashCount:
            type: integer
            format: uint64
          crashTimestamp:
            type: integer
            format: uint64

whereas in eirini, it is:

type LRPStatus struct {
    Replicas int32 `json:"replicas"`
}

These should be in sync, and preferably automatically in sync.