cloudfoundry / eirini

Pluggable container orchestration for Cloud Foundry, and a Kubernetes backend
Apache License 2.0
115 stars 30 forks source link

unsafe_allow_automount_service_account_token is not applied to task pods #106

Closed mnitchev closed 3 years ago

mnitchev commented 4 years ago

Description

Setting the unsafe_allow_automount_service_account_token option for eirini does not apply it to task Pods and instead always sets it to false. It should follow the same behaviour as for apps (see here and here)

Steps to reproduce

  1. Deploy eirini with unsafe_allow_automount_service_account_token: true
  2. Push an app and run a task

What was expected to happen

The tasks Pod doesn't have automountServiceAccountToken set

What actually happened

The tasks Pod has automountServiceAccountToken: false

Additional information (optional)

Original issue

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/174420433

The labels on this github issue will be updated when the story is started.