search

cloudfoundry / eirini

Pluggable container orchestration for Cloud Foundry, and a Kubernetes backend
Apache License 2.0
115 stars 30 forks source link

Set timeouts for requests to Kubernetes API #123

Closed braunsonm closed 3 years ago

braunsonm commented 3 years ago

Description

Currently it appears Eirini does not set a timeout when making calls to the Kubernetes API. In situations of network issues or load, requests may be left open for hours or more.

Steps to reproduce

Have Eirini send a request to a Kubernetes API endpoint that does not respond.

What was expected to happen

The request should eventually timeout

What actually happened

The request stays open forever.

Additional information (optional)

https://github.com/kubernetes/kubernetes/pull/17074

cf-gitbot commented 3 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/177416969

The labels on this github issue will be updated when the story is started.

gcapizzi commented 3 years ago

This is done! We have added a 60 seconds timeout for our calls to the Kubernetes API, and wired up everything so that cancelling the HTTP request to Eirini also cancels any calls to Kubernetes. Thanks for reporting this!