search

cloudfoundry / eirini

Pluggable container orchestration for Cloud Foundry, and a Kubernetes backend
Apache License 2.0
115 stars 30 forks source link

Org/space/app name annotations #83

Closed pianohacker closed 4 years ago

pianohacker commented 4 years ago

Description

The Log Egress (Loggregator) team would like to send logs from apps to many downstream consumers, most of which have historically depended on app metadata to help filter and annotate those logs. Some of those are native to the platform, like Log Cache, but others are offsite, such as Splunk, Papertrail, or AppDynamics. To make this happen, annotations on the StatefulSet/Pods with the name of the application, org and space would be extremely useful.

While it is possible for this information to become out of date using the cf rename-* commands, the current implementation in CF continues to send the original name, so it would be fine for Eirini not to update them.

Suggested Fix

Given that the cloudfoundry.org/application_name and space_name annotations already seem to exist (https://github.com/cloudfoundry-incubator/eirini/blob/ca5617920508538c055485a30362b4240b2d35ee/k8s/statefulset.go#L28), we suggest adding a cloudfoundry.org/org_name or organization_name annotation.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/169960936

The labels on this github issue will be updated when the story is started.

alex-slynko commented 4 years ago

This should work in the latest version. Feel free to reopen the issue if still see problems