search

cloudfoundry / eirini

Pluggable container orchestration for Cloud Foundry, and a Kubernetes backend
Apache License 2.0
115 stars 30 forks source link

Pod and Service labels consistency #85

Closed mike1808 closed 4 years ago

mike1808 commented 4 years ago

It'll be nice to have the same labels for pods and services to able to reuse the selector find services and pods corresponding to an app GUID. Right now pods have cloudfoundry.org/app_guid and cloudfoundry.org/guid labels and services have cloudfoundry.org/app.

AFAIK, having the same label is a good practice in Kubernetes which eases operators' experience and leverages tools working Kubernetes cluster to group objects under the same entity. https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

cc @ndhanushkodi

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/171067523

The labels on this github issue will be updated when the story is started.

rosenhouse commented 4 years ago

@mike1808 What service do you speak of? I didn't realize Eirini was creating services.

mike1808 commented 4 years ago

@rosenhouse 🤦‍♂ cfroutesync creates services. Closing the issue.

mike1808 commented 4 years ago

Created issue in cfroutesync repo https://github.com/cloudfoundry/cf-k8s-networking/issues/22