cloudfoundry / eirini

Pluggable container orchestration for Cloud Foundry, and a Kubernetes backend
Apache License 2.0
115 stars 30 forks source link

Have org/space/app name annotations on app pods, not just stateful sets #88

Closed pianohacker closed 3 years ago

pianohacker commented 4 years ago

Description

As a continuation of https://github.com/cloudfoundry-incubator/eirini/issues/83, it would be useful to have the cloudfoundry.org/application_name, space_name, and org_name annotations on the individual app pods, not just the statefulset. (For context, the Kubernetes filter we use in our Fluentd logging stack only pulls labels/annotations for the pod emitting the log.)

Steps to reproduce

Create an application using an Eirini, and compare the annotations on its statefulset and the resulting pods.

What was expected to happen

The following annotations to be present on the pods:

What actually happened

None of the annotations are present on the pods.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/171283209

The labels on this github issue will be updated when the story is started.