search

cloudfoundry / eirini

Pluggable container orchestration for Cloud Foundry, and a Kubernetes backend
Apache License 2.0
115 stars 30 forks source link

Parameterize baseimage in Dockerfiles #91

Closed jimmykarily closed 4 years ago

jimmykarily commented 4 years ago

This PR will allow the building of the images on a different base. For example, we need to build all the images with a SLE (SUSE Linux Enterprise) base for kubecf.

Relevant kubecf issue: https://github.com/cloudfoundry-incubator/kubecf/issues/744

This image was skipped: https://github.com/cloudfoundry-incubator/eirini/blob/master/docker/registry/certs/smuggler/Dockerfile

because the FROM line is not enough to change to another distro (there are apk commands in the Dockerfile) and we won't need this image in kubecf.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172477465

The labels on this github issue will be updated when the story is started.

jimmykarily commented 4 years ago

@viovanov do we still need this PR? We are also building FROM scratch and the one image that is Ubuntu based, we replace with sed : https://github.com/SUSE/scf-eirini-ci/blob/master/pipeline.yaml.gomplate#L358

would be cleaner if it was parameterized I guess.

viovanov commented 4 years ago

@jimmykarily yes, I think it's cleaner parameterized - and more consistent.