A short explanation of the proposed change:
Proxy and Roundtripper have lots of field that are basically just duplicated config properties. Adding a new config property and making use of it in either of them adds a lot of boiler plate code just to duplicate and copy the config property into a matching proxy / roundtripper property with no added value. If at all, confusion is added as to where the source value came from.
I've touched Proxy and RoundTripper in this change but there are probably more of those lurking in the code.
An explanation of the use cases your change solves
By adding a reference to the gorouter config and directly using it to read config values where they are needed, the intermediate duplicate & copy step is avoided which should lead to less clutter and more clarity overall.
No functional changes were made, this is a pure refactor change.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
run test suites. nothing should break.
Expected result after the change
n/a
Current result before the change
n/a
Links to any other associated PRs
[x] I have viewed signed and have submitted the Contributor License Agreement
[x] I have made this pull request to the main branch
[x] I have run all the unit tests using scripts/run-unit-tests-in-docker from routing-release.
[ ] (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
[ ] (Optional) I have run CF Acceptance Tests on bosh lite
I've touched Proxy and RoundTripper in this change but there are probably more of those lurking in the code.
No functional changes were made, this is a pure refactor change.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics) run test suites. nothing should break.
Expected result after the change n/a
Current result before the change n/a
Links to any other associated PRs
[x] I have viewed signed and have submitted the Contributor License Agreement
[x] I have made this pull request to the
mainbranch[x] I have run all the unit tests using
scripts/run-unit-tests-in-dockerfrom routing-release.[ ] (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
[ ] (Optional) I have run CF Acceptance Tests on bosh lite