added container network metrics

cloudfoundry / guardian

containers4life

Apache License 2.0

76 stars 42 forks source link

added container network metrics #417

Closed JVecsei1 closed 1 year ago

JVecsei1 commented 1 year ago

Added network metrics RxBytes/TxBytes as discussed in here.
Related to https://github.com/cloudfoundry/cf-networking-release/issues/64
Depends on
- https://github.com/cloudfoundry/cf-networking-release/pull/229
- Must be merged first: https://github.com/cloudfoundry/garden/pull/112

cf-gitbot commented 1 year ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

geofffranks commented 1 year ago

Code looks good. I added a question to the originating issue regarding cross-compatibility with other releases (diego + cf-networking) that we'll want to ensure is tested prior to merging.

geofffranks commented 1 year ago

@JVecsei1 while testing i noticed there was an additional commit on the add-network-metrics-v2 branch that didn't make it on this PR. is that desired here?

JVecsei1 commented 1 year ago

@JVecsei1 while testing i noticed there was an additional commit on the add-network-metrics-v2 branch that didn't make it on this PR. is that desired here?

That's fine. I squashed two commits after adding them to the PR branch. git diff add-network-metrics add-network-metrics-v2 also shows an empty result 👍