search

cloudfoundry / guardian

containers4life
Apache License 2.0
77 stars 44 forks source link

Pin otel/trace to v1.15.1 #423

Closed ebroberson closed 11 months ago

ebroberson commented 11 months ago

This is a follow up to:

Prevents the following bug:

$ go get -t -u ./... && go mod tidy && go mod vendor && go vet ./...
vendor/go.opentelemetry.io/otel/internal/global/trace.go:56:30: cannot use &tracerProvider{} (value of type *tracerProvider) as trace.TracerProvider value in variable declaration: *tracerProvider does not implement trace.TracerProvider (missing method tracerProvider)
vendor/go.opentelemetry.io/otel/internal/global/trace.go:104:10: cannot use val (variable of type *tracer) as trace.Tracer value in return statement: *tracer does not implement trace.Tracer (missing method tracer)
vendor/go.opentelemetry.io/otel/internal/global/trace.go:109:9: cannot use t (variable of type *tracer) as trace.Tracer value in return statement: *tracer does not implement trace.Tracer (missing method tracer)
vendor/go.opentelemetry.io/otel/internal/global/trace.go:130:22: cannot use &tracer{} (value of type *tracer) as trace.Tracer value in variable declaration: *tracer does not implement trace.Tracer (missing method tracer)
vendor/go.opentelemetry.io/otel/internal/global/trace.go:151:35: cannot use s (variable of type nonRecordingSpan) as trace.Span value in argument to trace.ContextWithSpan: nonRecordingSpan does not implement trace.Span (missing method span)
vendor/go.opentelemetry.io/otel/internal/global/trace.go:163:20: cannot use nonRecordingSpan{} (value of type nonRecordingSpan) as trace.Span value in variable declaration: nonRecordingSpan does not implement trace.Span (missing method span)
vendor/go.opentelemetry.io/otel/internal/global/state.go:53:15: impossible type assertion: current.(*tracerProvider)
    *tracerProvider does not implement trace.TracerProvider (missing method tracerProvider)
vendor/go.opentelemetry.io/otel/internal/global/state.go:54:17: impossible type assertion: tp.(*tracerProvider)
    *tracerProvider does not implement trace.TracerProvider (missing method tracerProvider)
vendor/go.opentelemetry.io/otel/internal/global/state.go:66:17: impossible type assertion: current.(*tracerProvider)
    *tracerProvider does not implement trace.TracerProvider (missing method tracerProvider)
vendor/go.opentelemetry.io/otel/internal/global/state.go:107:35: cannot use &tracerProvider{} (value of type *tracerProvider) as trace.TracerProvider value in struct literal: *tracerProvider does not implement trace.TracerProvider (missing method tracerProvider)
vendor/go.opentelemetry.io/otel/internal/global/trace.go:151:35: too many errors
cf-gitbot commented 11 months ago

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.