search

cloudfoundry / haproxy-boshrelease

A BOSH release for haproxy (based on cf-release's haproxy job)
Apache License 2.0
37 stars 81 forks source link

ssl_min/max_ver, pre_start_script, raw_blocks without names and raw_blocks_only config_mode, stats without authentication #657

Closed kinjelom closed 3 months ago

kinjelom commented 4 months ago

  1. pre_start_script: A script appended to the pre-start script of HAProxy job. This script allows the job to prepare the machine before starting HAProxy, for example, by setting the MTU to a custom value.

  2. ssl_min_ver and ssl_max_ver: These settings enforce minimum and maximum SSL versions for connections. If this option is set, the disable_tls_* options will be ignored.

  3. support for raw_blocks with or without names, this is more readable for blocks global and defaults, especially when applying the setting config_mode: raw_blocks_only. config_mode includes two modes:

    • auto: default, utilizes raw_config if defined; otherwise, it uses traditional configuration mixed with raw_blocks.
    • raw_blocks_only: uses only raw_blocks, ignoring other configurations.

  4. Ability to expose ha_proxy.stats without authentication.

plowin commented 4 months ago

Thx for the contribution, we will review it during the next week.

plowin commented 4 months ago

Hi @kinjelom, can you please resolve the conflict, a typo fix? I do not want to push to your fork's master branch.

kinjelom commented 4 months ago

Hi @kinjelom, can you please resolve the conflict, a typo fix? I do not want to push to your fork's master branch.

@plowin Sorry, I missed it, done.

plowin commented 3 months ago

@kinjelom , when rebasing, please also include the findings from the linter:

spec/haproxy/templates/haproxy_config/raw_blocks_spec.rb:92:1: C: [Correctable] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
spec/haproxy/templates/haproxy_config/stats_listener_spec.rb:88:1: C: [Correctable] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
kinjelom commented 3 months ago

@kinjelom , when rebasing, please also include the findings from the linter [...]

@plowin done, is everything okay now?

kinjelom commented 3 months ago

@plowin thanks for your support and patience

plowin commented 3 months ago

You are very welcome, thanks a lot for the contributions, released with https://github.com/cloudfoundry/haproxy-boshrelease/releases/tag/v14.0.0%2B2.8.9.

Feel free to also join us on Slack